Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(resources): align exported names in different environments #2739

Merged
merged 2 commits into from
Jan 29, 2022
Merged

fix(resources): align exported names in different environments #2739

merged 2 commits into from
Jan 29, 2022

Conversation

legendecas
Copy link
Member

Which problem is this PR solving?

Universal packages must export the same names in different environments to prevent confusion.

Short description of the changes

  • Export EnvDetector and ProcessDetector unconditionally.
  • Add browser tests on @opentelemery/resource.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Followed the style guidelines of this project
  • Unit tests have been added
  • Documentation has been updated

@codecov
Copy link

codecov bot commented Jan 26, 2022 •
edited
Loading

Codecov Report

Merging #2739 (adc3acf) into main (e1c32b2) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head adc3acf differs from pull request most recent head 1400232. Consider uploading reports for the commit 1400232 to get more accurate results

@@            Coverage Diff             @@
##             main    #2739      +/-   ##
==========================================
- Coverage   93.27%   93.26%   -0.02%     
==========================================
  Files         158      159       +1     
  Lines        5443     5447       +4     
  Branches     1141     1142       +1     
==========================================
+ Hits         5077     5080       +3     
- Misses        366      367       +1
Impacted Files Coverage Δ
...ges/opentelemetry-resources/src/detectors/index.ts 100.00% <ø> (ø)
...entelemetry-resources/src/detectors/EnvDetector.ts 88.23% <100.00%> (ø)
...lemetry-resources/src/detectors/ProcessDetector.ts 100.00% <100.00%> (ø)
packages/opentelemetry-sdk-trace-base/src/Span.ts 99.18% <0.00%> (-0.82%) ⬇️

@legendecas legendecas force-pushed the resource branch 2 times, most recently from 8ecbda8 to b1ef3b1 Compare January 26, 2022 05:35
@legendecas legendecas marked this pull request as ready for review January 26, 2022 05:43
@legendecas legendecas requested a review from a team January 26, 2022 05:43
@legendecas legendecas mentioned this pull request Jan 26, 2022
Merged
7 tasks
dyladan
dyladan approved these changes Jan 26, 2022
View reviewed changes
Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I wasn't aware of describeNode and describeBrowser functions.

@vmarchaud vmarchaud added the bug Something isn't working label Jan 26, 2022
@legendecas
Copy link
Member Author

Looks good. I wasn't aware of describeNode and describeBrowser functions.

They are added in this PR. :)

@dyladan
Copy link
Member

dyladan commented Jan 27, 2022

So they are :)

@vmarchaud vmarchaud merged commit 754d96d into open-telemetry:main Jan 29, 2022
@legendecas legendecas deleted the resource branch February 8, 2022 02:49
@dyladan dyladan mentioned this pull request Mar 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmarchaud vmarchaud vmarchaud approved these changes

@dyladan dyladan dyladan approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@legendecas @dyladan @vmarchaud